[FFmpeg-devel] [PATCH] Xxan decoder
Kostya
kostya.shishkov
Sat Dec 19 19:01:18 CET 2009
On Sat, Dec 19, 2009 at 06:37:51PM +0100, Michael Niedermayer wrote:
> On Sat, Dec 19, 2009 at 07:22:38PM +0200, Kostya wrote:
> > On Sat, Dec 19, 2009 at 02:45:44PM +0100, Diego Biurrun wrote:
> > > On Sat, Dec 19, 2009 at 01:38:02PM +0200, Kostya wrote:
> > > > Now as clean patch (without docs or field clarification).
> > >
> > > Neat, I need to test this soonish. Does it decode all samples?
> >
> > Seems so.
> >
> > > > I also recommend leaving it for some student to finish.
> > >
> > > Will that ever happen? :)
> >
> > Who knows, it's mostly style & small bugfixing anyway.
> >
> > [patch nits]
> > Now even closer to ideal ;)
>
> please also fix the issues ive raised or explain why not
> I dont mind at all if you disagree on some but please dont just fix a
> subset without comment on the remaining.
I think I've fixed a deal of your issues too except for giving better
names to bufferN variables (you know, developers and names ...)
> [...]
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
More information about the ffmpeg-devel
mailing list