[FFmpeg-devel] [Patch] Use Transfer-Encoding: chunked (and perhaps PUT) for HTTP uploads

[Mans Rullgard]

"Diego Biurrun" <diego at biurrun.de> wrote:

>On Tue, Dec 22, 2009 at 01:22:07PM +0100, Tomas H?rdin wrote:
>> 
>> --- libavformat/http.c	(revision 20911)
>> +++ libavformat/http.c	(working copy)
>> @@ -344,13 +348,49 @@
>> +
>> +        if ((ret = url_write(s->hd, temp, strlen(temp))) < 0)
>> +            return ret;
>> +
>> +        /* chunk-data */
>> +        if ((ret = url_write(s->hd, buf, size)) < 0)
>> +            return ret;
>> +
>> +        /* CRLF */
>> +        if ((ret = url_write(s->hd, crlf, sizeof(crlf) - 1)) < 0)
>> +            return ret;
>
>These if statements can be merged ..

No.

>> +
>> +    /* signal end of chunked encoding if used */
>> +    if ((h->flags & URL_WRONLY) && s->chunksize != -1) {
>> +        if ((ret = url_write(s->hd, footer, sizeof(footer) - 1)) < 0)
>> +            return ret;
>
>.. as can these two ..

yes
-- 
Mans Rullgard
mans at mansr.com