[FFmpeg-devel] [PATCH] Proper Interplay Video 16-bit support

[Diego Biurrun]

On Wed, Dec 23, 2009 at 01:28:27PM +0200, Kostya wrote:
> On Wed, Dec 23, 2009 at 11:40:26AM +0100, Diego Biurrun wrote:
> > On Fri, Dec 18, 2009 at 10:56:48PM +0200, Kostya wrote:
> > > Here's proper Interplay Video 16-bit support with separate decoder made
> > > by svn cp from existing one. Demuxer now distinguishes them without any
> > > problems too.
> > > 
> > > P.S. I'm pretty sure Diego will love this codec ID.
> > 
> > I still wonder why...
> 
> It's looooooooong and breaks vertical alignment somewhere.

I'm sorry your patch is rejected in its current form then.
The decision is final.

;-p

> > > P.D.F. I know it can be merged into single decoder but if you want that,
> > > make it small or GSoC qualification task.
> > 
> > Oh, that will likely never happen, but you could accomplish it
> > in hours.  Get that motivation up :)
> 
> Why do I have that strange feeling of deja vu?

You keep doing the same things, no wonder you get the same reactions :)

> > > --- libavcodec/ipvideo16.c	(revision 20496)
> > > +++ libavcodec/ipvideo16.c	(working copy)
> > > @@ -69,13 +69,22 @@
> > >  
> > > +#define CHECK_MV_PTR(n) \
> > > +  if (s->mv_end - s->mv_ptr < n) { \
> > > +    av_log(s->avctx, AV_LOG_ERROR, "Interplay video warning: mv_ptr out of bounds (%p >= %p)\n", \
> > > +      s->mv_ptr + n, s->mv_end); \
> > > +    return -1; \
> > > +  }
> > 
> > Indentation is partly off and only two sapces.
> 
> Yep, totally inherited from original file. Why don't run through those
> old files and reformat them a bit to modern standards. Nobody can beat
> you in that area for sure.
> 
> Here's a quick list:
> 8bps.c
> idcinvideo.c
> smc.c
> svq1dec.c
> tscc.c
> 
> and everything with CHECK_STREAM_PTR

A reasonable request; I shall look into it.

Diego