[FFmpeg-devel] [PATCH] Simplify libSDL configuration

Måns Rullgård mans
Thu Dec 24 00:36:26 CET 2009


Diego Biurrun <diego at biurrun.de> writes:

> On Tue, Dec 22, 2009 at 11:31:46PM +0100, Stefano Sabatini wrote:
>> Hi, this resulted harder than I thought.
>
> What's the intention of this patch?  It seems to mix multiple issues.

The intent is of course to get rid of some uglies in configure.

>> --- ffmpeg.orig/ffplay.c	2009-12-22 21:01:10.000000000 +0100
>> +++ ffmpeg/ffplay.c	2009-12-22 21:07:11.000000000 +0100
>> @@ -32,8 +32,8 @@
>>  
>> -#include <SDL.h>
>> -#include <SDL_thread.h>
>> +#include <SDL/SDL.h>
>> +#include <SDL/SDL_thread.h>
>
> This looks good to me.

I bet there's at least one distro with the headers somewhere else.

>> --- ffmpeg.orig/Makefile	2009-12-22 23:10:12.000000000 +0100
>> +++ ffmpeg/Makefile	2009-12-22 23:11:37.000000000 +0100
>> @@ -76,8 +75,6 @@
>>  
>> -ffplay.o ffplay.d: CFLAGS += $(SDL_CFLAGS)
>
> This could probably be applied along with the #include path fix.

See above.  Please don't apply this yet.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list