[FFmpeg-devel] [PATCH] Simplify libSDL configuration

[Reimar Döffinger]

On Thu, Dec 24, 2009 at 12:46:34PM +0100, Reimar D?ffinger wrote:
> On Thu, Dec 24, 2009 at 12:17:51PM +0100, Stefano Sabatini wrote:
> > On date Thursday 2009-12-24 11:14:22 +0100, Stefano Sabatini encoded:
> > > On date Thursday 2009-12-24 11:46:55 +0200, Kostya encoded:
> > > > On Thu, Dec 24, 2009 at 10:41:08AM +0100, Reimar D?ffinger wrote:
> > > > > On Tue, Dec 22, 2009 at 11:31:46PM +0100, Stefano Sabatini wrote:
> > > > > > I'm not sure if -D_GNU_SOURCE=1 -D_REENTRANT may break something.
> > > > > 
> > > > > 
> > > > > -D_GNU_SOURCE=1 is horrible and should be avoided if at all possible,
> > > > > we do not want to risk infestation by GNUism, if SDL needs this it
> > > > > desperately needs to be fixed.
> > > > 
> > > > It also needs not to swap chroma planes on MacOSX/PPC but nobody cares.
> > > 
> > > Yesterday I tried to compile ffplay with libSDL SVN (1.3.0), it can
> > > compile fine but then when I tried to play a video there were lots of
> > > problems (playback was not smooth, either too fast or too slow,
> > > sometimes it stopped, threading issue?).
> > > 
> > > And I agree GNU-ism should be avoided, I'll report / fix it if I'll
> > > find time for it.
> > 
> > http://bugzilla.libsdl.org/show_bug.cgi?id=915
> > 
> > Let's see how they'll react.
> 
> Have you checked it is actually needed?
> I don't care if they use it for their main source, but I really think it
> shouldn't be hard to make the headers work (at least also) with only plain C99.

And even for their main source (SVN at least) it is completely
unnecessary. Would probably be good to add to the bugreport that
1) it is completely unneeded
2) it ends up in the pkg_config flags where it might cause all kinds of
confusion for apps using SDL, possibly even breaking compilation due to
namespace collisions caused by GNU extensions.