[FFmpeg-devel] [PATCH] Fix SDP demuxer dependencies

[Reimar Döffinger]

On Tue, Dec 29, 2009 at 11:22:05AM +0100, Luca Abeni wrote:
> Hi Reimar,
> 
> On 28/12/09 20:16, Reimar D?ffinger wrote:
> >>>>Well, on line 111 it uses&asf_demuxer, and thus directly references a
> >>>>symbol from asfdec.c.
> >>>
> >>>Oh, right... Hmm... Have to figure out how to get rid of that, for now
> >>>the patch is ok then (as Luca said).
> >>
> >>It should only be a very quick patch to change the hardcoded demuxer to
> >>use av_find_input_format instead.
> >
> >Untested, and I fear it will crash if there is no asf demuxer (as does
> >the current code if for some reason av_open_input_stream fails I
> >suspect?), but this should do it:
> [...]
> 
> Thanks for the patch; I believe this is the right approach!
> 
> If someone with some knowledge of this microsoft's RTP ASF thing can
> test and finalize it, I think the patch should be committed.
> (of course, if testing the patch and fixing the crash takes too much
> time, I think the original patch by Martin could be committed as a
> temporary workaround, until the correct solution is ready).

Note: the crash is not new, at least I believe the assumption that av_open_input_stream
can not fail was never justified - as such I think it doesn't really make
anything worse.
It should still be fixed though, but I'd consider it independent.