[FFmpeg-devel] [PATCH] [H.263] remove disabled code cruft

[Michael Niedermayer]

On Wed, Dec 30, 2009 at 02:00:25PM +0100, Diego Biurrun wrote:
> On Sat, Dec 26, 2009 at 06:22:42PM +0100, Diego Biurrun wrote:
> > $subject, as attached
> > 
> > --- libavcodec/h263.c	(revision 20925)
> > +++ libavcodec/h263.c	(working copy)
> > @@ -3019,13 +3008,6 @@
> >  
> > -static inline void memsetw(short *tab, int val, int n)
> > -{
> > -    int i;
> > -    for(i=0;i<n;i++)
> > -        tab[i] = val;
> > -}
> > -
> >  
> > @@ -3248,13 +3228,6 @@
> >  
> > -#if 0
> > -    /* clean DC */
> > -    memsetw(s->dc_val[0] + l_xy, 1024, l_wrap*2+1);
> > -    memsetw(s->dc_val[1] + c_xy, 1024, c_wrap+1);
> > -    memsetw(s->dc_val[2] + c_xy, 1024, c_wrap+1);
> > -#endif
> 
> I just noticed that this is an exact duplicate of msmpeg4_memsetw.
> This should be a good reason to remove it.

the memsetw() yes but not the other hunk.
Also please dont remove the memsetw() and then argue that the other
should be removed because it doesnt compile anymore

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 3
"Rare item" - "Common item with rare defect or maybe just a lie"
"Professional" - "'Toy' made in china, not functional except as doorstop"
"Experts will know" - "The seller hopes you are not an expert"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091231/a3f23a85/attachment.pgp>