[FFmpeg-devel] [PATCH] Make RM demuxer behave better with -an option

Ronald S. Bultje rsbultje
Mon Feb 2 19:37:12 CET 2009


On Mon, Feb 2, 2009 at 2:19 PM, Kostya <kostya.shishkov at gmail.com> wrote:
> The story so far:
>  FFmpeg now has RV30, RV40 (my fault) and AAC (not my fault) support. When
> trying to decode RV40+AAC RM file with -an option video decoder produces
> a lot of garbage and may crash. As I've investigated, that happens because
> with -an option specified RM demuxer begins to feed audio packets to video
> decoder.

My personal opinion is that that piece of code is dirty anyway
(ff_rm_parse_packet() for AAC doesn't read the complete RM packet, but
just one AAC frame), whereas for others (ATRAC3, cook, etc.) it reads
the multiple packets and stores them in ast->buf. Maybe for AAC, it
should do that also. That also allows to get rid of the special case
in ff_rm_retrieve_cache().

Anyway, if you don't want to go that far, this works too, yes.
("Ignore this if you don't care.")

Ronald




More information about the ffmpeg-devel mailing list