[FFmpeg-devel] [PATCH] RTSP-MS 10/15: ASF header parsing

[Michael Niedermayer]

estOn Wed, Feb 04, 2009 at 12:38:48PM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Wed, Feb 4, 2009 at 12:24 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Wed, Feb 04, 2009 at 11:53:02AM -0500, Ronald S. Bultje wrote:
> >> On Wed, Feb 4, 2009 at 11:48 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> > and then one wonders why the enum is part of the public api at all?
> >>
> >> Right, so the add_comments.patch (other mail) comments that it isn't,
> >> similar as for LOWER_TRANSPORT_LAST.
> >
> > let me ask i differently
> > why is the enum in a installed public header?
> 
> It's used in RTSPState, which is used in some rtp*.c files as well.
> 
> If it were a struct, I'd have defined it opaquely and declare it only
> within rtsp.c, but C unfortunately does not support that concept for
> enums (i.e. enum RTSPTransport in rtsp.h and then enum RTSPTransport {
> .. } in rtsp.c).

Why is RTSPState in a public header?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090204/d9bcfca0/attachment.pgp>