[FFmpeg-devel] [PATCH] H.264: fix decoding of plain still images (broken since revision 14289)

[Reinhard Nissl]

Hi,

Reimar D?ffinger schrieb:
> On Sun, Jan 04, 2009 at 04:18:10PM +0100, Reinhard Nissl wrote:
>> Well, didn't have a look into the spec so far, but my sample
>> files just contain a single I picture (either a frame or a pair
>> of fields). Decoding works without problem but the decoded
>> picture is simply not output, starting with that revision.
> 
> Are you sure you didn't just forget to get the delayed pictures by
> calling decode_frame with no input data until you get no more frames?

Hhm, you are right, I do not do this, because it would be rather
complex to detect this scenario when data is fed via a pipe to
xine-lib and data only arrives when for example a different still
image is to be shown on a certain user action (pipe is not closed
between showing still images).

But the samples end in a sequence end NAL which should be
sufficient to output just this single picture too.

> If you don't do that even normal files will miss frames.
> Also, did you test with ffmpeg to make sure the error is not in your
> code?

The readme.txt in the sample subdirectory rnissl mentions this
commands to show the issue:

	ffplay -f h264 still_frame.es.264
	ffplay -f h264 still_fields.es.264

Bye.
-- 
Dipl.-Inform. (FH) Reinhard Nissl
mailto:rnissl at gmx.de