[FFmpeg-devel] [PATCH]VDPAU patch for MPEG1/2 decoding, round 1

Gwenole Beauchesne gbeauchesne
Mon Jan 5 18:11:02 CET 2009


Hi,

On Mon, 5 Jan 2009, Reimar D?ffinger wrote:

>> @@ -1212,6 +1213,28 @@
>>      }
>>  }
>>
>> +static void mpeg_set_pixelformat(AVCodecContext *avctx){
>> +    Mpeg1Context *s1 = avctx->priv_data;
>> +    MpegEncContext *s = &s1->mpeg_enc_ctx;
>> +
>> +    if(avctx->codec->capabilities&CODEC_CAP_HWACCEL_VDPAU){
>
> IMO CODEC_CAP_HWACCEL_VDPAU should not be used at all, checking codec_id
> seems like the sanest way to me currently.

What about such occurrence in mpegvideo.c? Enumerating all codec_id would 
be rather suboptimal. Or, is it considered sane only in that file?

Thanks,
Gwenole.



More information about the ffmpeg-devel mailing list