[FFmpeg-devel] [PATCH] Drop AVFrac at the next lavf major bump

[Diego Biurrun]

On Mon, Jan 05, 2009 at 11:18:29PM +0100, Michael Niedermayer wrote:
> On Mon, Jan 05, 2009 at 10:23:47PM +0100, Diego Biurrun wrote:
> > On Mon, Jan 05, 2009 at 09:10:41PM +0000, M?ns Rullg?rd wrote:
> > > Michael Niedermayer <michaelni at gmx.at> writes:
> > > 
> > > > On Mon, Jan 05, 2009 at 01:09:48AM +0100, Stefano Sabatini wrote:
> > > >> Hi all, this is just to revive the old discussions about the removal
> > > >> of AVFrac.
> > > >> 
> > > >> Related threads:
> > > >> http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/60413
> > > >> http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/38380
> > > >> 
> > > >> I picked up the Mans patch, with some little modifications to avoid to
> > > >> break backward compatibility, yes it's done with ugly ifvers but I
> > > >> don't think there are better ways... apart from bump major seems there
> > > >> seems to be many important changes (metadata API) in these days.
> > > >> 
> > > >> I think the AVRational64 approach is correct, since it shouldn't lose
> > > >> precision, unfortunately there is some regressions which I think are
> > > >> due to some roundings, I still didn't investigate but I will do if you
> > > >> like the approach.
> > > >
> > > > What is the point of "renaming" AVFrac to AVRational64 ?
> > > > we could just keep AVFrac ...
> > > 
> > > You were the one who marked AVFrac deprecated.  I assumed you had a
> > > reason for this.
> 
> i did, i thought we could avoid it just by AVRational & int64_t but this
> didnt work out
> 
> > 
> > Patch to solve the issue attached..
> 
> ok

Applying in a moment after the last compilation test has finished.

Diego