[FFmpeg-devel] [PATCH]VDPAU patch for MPEG1/2 decoding, round 4

[Carl Eugen Hoyos]

Michael Niedermayer <michaelni <at> gmx.at> writes:

> > +    PIX_FMT_VDPAU_MPEG1,///< MPEG1 HW decoding with VDPAU, data[0] contains
a vdpau_render_state
> struct which contains the bitstream of the slices as well as various fields
extracted from headers
> > +    PIX_FMT_VDPAU_MPEG2,///< MPEG2 HW decoding with VDPAU, data[0] contains
a vdpau_render_state
> struct which contains the bitstream of the slices as well as various fields
extracted from headers
> 
> are 2 really needed?

It might be possible with one (I did not succeed yet), but in any case, it would
mean that the calling application (MPlayer) would have to test avctx->codec_id
to find out if it's MPEG1 or MPEG2 (HW has to know what, it can't decode
otherwise) - isn't that a bad idea?

> > +#undef interlaced_dct
> > +#undef mb_intra
> 
> It may be better to remove the 2 offending #defines from h264.h if no
> other solution is found

I was hoping that I do not have to resend since I solved the issue myself...

Carl Eugen