[FFmpeg-devel] Broken compile with latest libavutil/common.h

[Chris Silva]

Revision r16590 and up break xine-lib compile. Latest working revision
is r16589.

Error is this:

 /bin/bash ../../../libtool --tag=CC   --mode=compile gcc
-DHAVE_CONFIG_H -I. -I../../../include -I../../.. -I../../../include
-I../../../include -I../../../src -I../../../src/xine-engine
-I../../../src/xine-engine -I../../../src/xine-utils
-I../../../src/input -I../../../src/input  -I../../../lib
-I../../../lib   -fvisibility=hidden -I/usr/local/include
-I/usr/local/include   -fomit-frame-pointer -D_REENTRANT
-D_FILE_OFFSET_BITS=64 -DXINE_COMPILE  -O3 -fomit-frame-pointer
-fexpensive-optimizations -fschedule-insns2 -ffast-math
-finline-functions  -Wpointer-arith -g -O2 -Wall -Wchar-subscripts
-Wnested-externs -Wcast-align -Wmissing-declarations
-Wmissing-prototypes -Wmissing-format-attribute -Wformat=2
-Wno-format-zero-length -Wstrict-aliasing=2
-Werror=implicit-function-declaration -DNDEBUG -MT
xineplug_post_planar_la-pp.lo -MD -MP -MF
.deps/xineplug_post_planar_la-pp.Tpo -c -o
xineplug_post_planar_la-pp.lo `test -f 'pp.c' || echo './'`pp.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../../include
-I../../.. -I../../../include -I../../../include -I../../../src
-I../../../src/xine-engine -I../../../src/xine-engine
-I../../../src/xine-utils -I../../../src/input -I../../../src/input
-I../../../lib -I../../../lib -fvisibility=hidden -I/usr/local/include
-I/usr/local/include -fomit-frame-pointer -D_REENTRANT
-D_FILE_OFFSET_BITS=64 -DXINE_COMPILE -O3 -fomit-frame-pointer
-fexpensive-optimizations -fschedule-insns2 -ffast-math
-finline-functions -Wpointer-arith -g -O2 -Wall -Wchar-subscripts
-Wnested-externs -Wcast-align -Wmissing-declarations
-Wmissing-prototypes -Wmissing-format-attribute -Wformat=2
-Wno-format-zero-length -Wstrict-aliasing=2
-Werror=implicit-function-declaration -DNDEBUG -MT
xineplug_post_planar_la-pp.lo -MD -MP -MF
.deps/xineplug_post_planar_la-pp.Tpo -c pp.c  -fPIC -DPIC -o
.libs/xineplug_post_planar_la-pp.o
In file included from /usr/local/include/libavutil/avutil.h:56,
                       from /usr/local/include/libpostproc/postprocess.h:30,
                       from pp.c:35:
/usr/local/include/libavutil/common.h:326:14: error: operator '||' has
no left operand
pp.c: In function 'get_help':
pp.c:127: warning: ignoring return value of 'asprintf', declared with
attribute warn_unused_result
pp.c: In function 'pp_draw':
pp.c:336: warning: passing argument 1 of 'pp_postprocess' from
incompatible pointer type
make[3]: *** [xineplug_post_planar_la-pp.lo] Error 1
make[3]: Leaving directory `/usr/local/src/xine-vdpau/src/post/planar'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/usr/local/src/xine-vdpau/src/post'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/usr/local/src/xine-vdpau/src'
make: *** [all-recursive] Error 1

Looking at aurel commit (r16590) on libavutil/common.h file, we see
that line 326 changed as follows:

@@ -323,9 +323,9 @@ static inline av_pure int ff_get_fourcc(const char *s){
         }\
     }

-#if defined(ARCH_X86) || defined(ARCH_PPC) || defined(ARCH_BFIN)    <
---- line 326
+#if ARCH_X86 || ARCH_PPC || ARCH_BFIN
 #define AV_READ_TIME read_time
-#if defined(ARCH_X86)
+#if ARCH_X86
 static inline uint64_t read_time(void)
 {

Is this a xine-lib problem or a ffmpeg problem?

Anyway, just wanted to warn you guys.

Happy coding