[FFmpeg-devel] [RFC] avfilter_request_frame() crash

[Vitor Sessak]

Stefano Sabatini wrote:
> Hi all,
> 
> when calling avfilter_request_frame() on a link with no source it
> crashes, for example with:
> 
> ffplay -f video4linux -s 320x240 /dev/video -vfilters "[in] setpts=PTS-STARTPTS, hflip, setpts=PTS-STARTPTS [foo]"
> 
> Should we:
> 1) add a check in avfilter_request_frame(), so that it will return -1
>    if the link source is NULL
> 2) ensure that no dangling links exist before to start to extract
>    filters from the filterchain
> 3) both 1) and 2)

I'd say (2) or (3), I don't think "[in] setpts=PTS-STARTPTS, hflip, 
setpts=PTS-STARTPTS [foo]" should be considered a valid description of a 
filter chain.

-Vitor