[FFmpeg-devel] [PATCH] VC-1: Faster C loopfilter

Jason Garrett-Glaser darkshikari
Sun Jan 18 08:04:29 CET 2009


On Sun, Jan 18, 2009 at 2:40 AM, Kostya <kostya.shishkov at gmail.com> wrote:
> On Sat, Jan 17, 2009 at 11:54:51PM -0500, Jason Garrett-Glaser wrote:
>> Yuvi requested I optimize this one, so I did.  This patch can be
>> summed up as follows:
>>
>> 13:20 <@mru> I see a lot of xor
>> 13:20 <@mru> that's usually a sign of magic
>>
>> 338 -> 315 cycles for vc1_loop_filter on Core 2 Duo.
>> Overall decoding 12.047s -> 11.781s
>>
>> Dark Shikari
>
> Err, welcome to the dark side :)
>
> Patch looks ok except for redundant comments for FFABS.

I thought those comments would be useful as ugly hacks like mine are
generally not very clear, but if you prefer not to have them after the
first, feel free to remove them as you wish when you apply.  I don't
think there's any point in me sending another patch just to remove
those.

>Can you also submit a small patch for supporting interlaced modes in VC-1?

After you submit a small patch to add full MBAFF support to x264 ;)

Dark Shikari




More information about the ffmpeg-devel mailing list