[FFmpeg-devel] a64 encoder

[Aurelien Jacobs]

Bitbreaker/METALVOTZE wrote:

> > is your code better then our elbg ? if so replace elbg.c/h by it
> > if its worse you should use elbg.c/h (possibly with adaptions in elbg to
> > handle the small number of colors)
> 
> elbg code is used now, as it is way faster at similar quality. So code 
> size shrank again, and i am happy to present the third iteration :-)
> 
> [...]
> 
> Index: libavformat/a64.c
> ===================================================================
> --- libavformat/a64.c	(Revision 0)
> +++ libavformat/a64.c	(Revision 0)
> @@ -0,0 +1,96 @@
> +/*
> + * a64 muxer and demuxer

There is no demuxer here.

> +[...]
> +
> +#ifdef CONFIG_A64_MUXER
> +AVOutputFormat a64_muxer = {
> +    .name = "a64",
> +    .long_name = NULL_IF_CONFIG_SMALL("a64 - video for commodore 64"),
> +    .mime_type = NULL,
> +    .extensions = "a64, A64",
> +    .priv_data_size = sizeof(A64Context),
> +    .video_codec = CODEC_ID_A64_ECM_HYBRID,
> +    a64_write_header,
> +    a64_write_packet,
> +};
> +#endif

You can't use #idef CONFIG_* anymore. You have to use #if CONFIG_.
But anyway, it's not needed at all here !

And BTW, you shoud probably rename this file to a64enc.c (in prevision
of a potential future a64dec.c).

Aurel