[FFmpeg-devel] AVRandomState usage in ffserver/RTP/RTSP

[Michael Niedermayer]

On Wed, Jan 21, 2009 at 08:21:58PM +0100, Stefano Sabatini wrote:
> On date Tuesday 2009-01-20 12:01:36 -0800, Baptiste Coudurier encoded:
> > Stefano Sabatini wrote:
> > > On date Monday 2009-01-19 00:18:04 +0100, Stefano Sabatini encoded:
> > >> On date Tuesday 2009-01-06 22:50:44 +0100, Stefano Sabatini encoded:
> > > [...]
> > >>> Index: ffmpeg/ffserver.c
> > >>> ===================================================================
> > >>> --- ffmpeg.orig/ffserver.c	2009-01-05 17:24:43.000000000 +0100
> > >>> +++ ffmpeg/ffserver.c	2009-01-05 17:31:35.000000000 +0100
> > >>> @@ -4468,6 +4468,7 @@
> > >>>  int main(int argc, char **argv)
> > >>>  {
> > >>>      struct sigaction sigact;
> > >>> +    struct timeval tv;
> > >>>  
> > >>>      av_register_all();
> > >>>  
> > >>> @@ -4483,7 +4484,8 @@
> > >>>  
> > >>>      unsetenv("http_proxy");             /* Kill the http_proxy */
> > >>>  
> > >>> -    av_random_init(&random_state, av_gettime() + (getpid() << 16));
> > >>> +    gettimeofday(&tv, NULL);
> > >>> +    av_random_init(&random_state, tv.tv_usec);
> > >>>  
> > >>>      memset(&sigact, 0, sizeof(sigact));
> > >>>      sigact.sa_handler = handle_child_exit;
> > >> Ping?
> > > 
> > > Ping2.
> > > 
> > 
> > I'd say it's better, yes, any other opinion ?
> 
> I'd say if it's OK with you and there are no better ideas I'll
> apply it in a week.

i suggest /dev/(u)random, if its unavailable something less good can always
be used as fallback


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

> ... defining _GNU_SOURCE...
For the love of all that is holy, and some that is not, don't do that.
-- Luca & Mans
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090121/7b9f31c1/attachment.pgp>