[FFmpeg-devel] [PATCH] Electronic Arts TQI decoder

[Diego Biurrun]

On Sun, Jan 25, 2009 at 11:06:25PM +1100, Peter Ross wrote:
> Patch enclosed.
> 
> eatqi-demux-r2.diff
> eatqi-decoder-r2.diff -- self explanatory.
> bitstream-ea32.diff -- yet another bitstream packing technique.
> ff_mpeg12_vlc.diff -- MPEG1/2 DC VLCs are reused
> 
> --- libavcodec/bitstream.h	(revision 16768)
> +++ libavcodec/bitstream.h	(working copy)
> @@ -34,7 +34,7 @@
>  
> -#if defined(ALT_BITSTREAM_READER_LE) && !defined(ALT_BITSTREAM_READER)
> +#if (defined(ALT_BITSTREAM_READER_LE)||defined(ALT_BITSTREAM_READER_EA32)) && !defined(ALT_BITSTREAM_READER)

some spaces around || maybe?

> --- libavcodec/eatqi.c	(revision 0)
> +++ libavcodec/eatqi.c	(revision 0)
> @@ -0,0 +1,255 @@
> +
> +/*
> +  the tqi bitstream is read using most-to-least order (standard BE get bits),

Capitalize.

> +static av_cold int tqi_decode_init(AVCodecContext *avctx){

For new files, I think you should use K&R-style function declarations.

You are missing the documentation update.

Diego