[FFmpeg-devel] [PATCH] remove unused and broken test program in libavutil/base64.c

[Diego Biurrun]

On Mon, Jan 26, 2009 at 11:28:18PM +0100, Stefano Sabatini wrote:
> On date Sunday 2009-01-25 10:42:53 +0100, Diego Biurrun encoded:
> > On Sat, Jan 24, 2009 at 09:48:16PM +0100, Stefano Sabatini wrote:
> > > On date Friday 2009-01-23 09:53:41 +0100, Diego Biurrun encoded:
> > > > On Thu, Jan 22, 2009 at 12:09:19AM +0100, Stefano Sabatini wrote:
> > > > > On date Thursday 2009-01-22 00:04:13 +0100, Diego Biurrun encoded:
> > > > > > I found some more cruft in the attic: a forgotten test program in
> > > > > > libavutil/base64.c.  It never compiled, not even the day it was
> > > > > > committed, since it calls av_base64_encode() with a wrong number
> > > > > > of parameters.
> > > > > > 
> > > > > > OK to remove?
> > > > > 
> > > > > Why not to simply fix it?
> > > > 
> > > > The question is whether it is worth the trouble.  Given that it is
> > > > proven that nobody ever used this program, I believe it to be
> > > > doubtful that anybody will in the future.
> > > > 
> > > > Of course you can have a stab at fixing it...
> > > 
> > > It turned out in a semi-complete rewrite of the test program, anyway I
> > > don't feel like to send a patch and discuss every single change, if
> > > it's possible to simply replace the new code I'll happily do it.
> > > 
> > > Follows the new test code:
> > > ----------8<--------------------8<--------------------------------
> > > //#define TEST
> > > #ifdef TEST
> > 
> > You don't need the #define, just add the file to the TESTS line in
> > the Makefile.
> > 
> > > int main()
> > 
> > void
> 
> Done, let me know if it is OK to apply.

Dunno, but ..

> --- libavutil/base64.c	(revision 16808)
> +++ libavutil/base64.c	(working copy)
> @@ -104,124 +104,114 @@
>  
> -int main(void)
> +int main()

As I said, this was correct before.

> --- libavutil/Makefile	(revision 16808)
> +++ libavutil/Makefile	(working copy)
> @@ -41,7 +41,7 @@
>  
> -TESTS = $(addsuffix -test$(EXESUF), adler32 aes crc des lls md5 pca random sha1 softfloat tree)
> +TESTS = $(addsuffix -test$(EXESUF), adler32 base64 aes crc des lls md5 pca random sha1 softfloat tree)

What might be wrong here? :)


Diego