[FFmpeg-devel] [PATCH][6/8] Add VA API accelerated VC-1 decoding

[Måns Rullgård]

Kostya wrote:
> On Thu, Jan 29, 2009 at 07:04:44PM +0100, Gwenol? Beauchesne wrote:
>> Hi,
>>
>> Le 29 janv. 09 ? 19:45, Kostya a ?crit :
>>
>> >> I have amended the VC1Context struct to record PICTURE::BFRACTION,
>> >> ENTRYPOINT_LAYER::BROKEN_LINK and ENTRYPOINT_LAYER::CLOSED_ENTRY
>> >> fields from the bitstream.
>> >
>> > Please send that amendment as a separate patch and with more
>> > meaningful
>> > comments to the structure members. It would also make reviewing your
>> > changes to vc1.c easier.
>>
>> OK, but what would be more meaningful than the actual SMPTE spec
>> names? Do you want the chapter/verse reference or the paragraph title
>> for the fields from the spec? It's just a verbatim copy of the
>> bitstream values.
>
> Well, ///< Comments LIKE::THIS  make me shudder. Short textual information
> describing that field is better than just simple name. Something like
> "Index for BFRACTION value", "Flag indicating that current GOP has something"
> would be better. vc1.h should have some examples.

Does the spec use all-caps names?  Such horrors...

-- 
M?ns Rullg?rd
mans at mansr.com