[FFmpeg-devel] [PATCH] convert to S16 when resampling is requested

[Michael Niedermayer]

On Fri, Jan 30, 2009 at 12:17:02PM -0800, Baptiste Coudurier wrote:
> Hi Michael,
> 
> Michael Niedermayer wrote:
> > On Sat, Dec 13, 2008 at 03:53:15PM -0800, Baptiste Coudurier wrote:
> >> Hi Michael,
> >> 
> >> Michael Niedermayer wrote:
> >>> On Fri, Dec 12, 2008 at 12:03:17PM -0800, Baptiste Coudurier
> >>> wrote:
> >>>> Hi,
> >>>> 
> >>>> $subject.
> >>> I think the audio resampler should support all input & output
> >>> sample formats instead. This would be similar to swscale and
> >>> would be much easier to use for applications than having these
> >>> steps seperated
> >> Well, yes, however you suggested that 3 months ago and nobody
> >> jumped in to work on it. In the mean time, there is still a big
> >> regression in FFmpeg, and I don't see anything fixed in the near
> >> future, so this workaround is IMHO acceptable until the most
> >> elegant solution is implemented.
> > 
> > what about moving your solution into the resampler?
> > 
> > I mean, so that one can later replace the X->S16->Y code by something
> >  better without having to change the API/ABI
> 
> I just looked at it and API does not provide a way to specify input
> sample format, so we cannot do this without changing it.

Indeed


> 
> Btw, is there something special to deal with when resampling > 2
> channels ? 

nothing i could think of ATM


> Why isn't it supported exactly ?

probably because the old resampler didnt support it and i was to lazy
to fix something, i dont remember exactly

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090130/ca4f701f/attachment.pgp>