[FFmpeg-devel] [PATCH] [ISSUE 793] Fix mp3 identification regressions

[Alex Converse]

On Fri, Jan 30, 2009 at 4:46 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Thu, Jan 29, 2009 at 12:31:52PM -0500, Alex Converse wrote:
>> On Thu, Jan 29, 2009 at 12:28 PM, Alex Converse <alex.converse at gmail.com>wrote:
>>
>> > Right now MP3 files with ID3v2 tags bigger than 2MB no longer identify as
>> > MP3. This patch makes the mp3 probe return 1 on files with id3v2 tags where
>> > mp3 was not identified to make these files identiy as MP3 on the last probe
>> > pass. A more elegant solution would be for the probes to be able to request
>> > seeking, however it seems that that would piss all over the API. I know
>> > Michael had suggested a return value to request more data in general but in
>> > theory ID3v2 can grow over 256 MB and I'm nto sure we'd want to sent that
>> > much information to the probe.
>> >
>>
>> I suppose it might be helpful if I actually attach the patch.
>
> iam not against this patch id just like to make sure you understand that
> it will not be nearly as reliably as you might think, other codecs also
> make wild guesses and return 1 on random data on occasion
>

I see what you are saying here. The old code used to give us
AVPROBE_SCORE_MAX/2+1 on all files that had id3v2 tags. Do you think
return AVPROBE_SCORE_MAX/4-1 would be appropriate for any file with an
id3v2 tag?

> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> The worst form of inequality is to try to make unequal things equal.
> -- Aristotle
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iD8DBQFJg3VBYR7HhwQLD6sRAlAQAJ97pDxX9r9i5ncE8q6qkD5O93b07ACfelsT
> v7Hn40RKKJh8LgFVoPSui7I=
> =r3zS
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>