[FFmpeg-devel] [PATCH] asfdec: division by 0 on missing packet size

[Michael Niedermayer]

On Thu, Jul 02, 2009 at 03:24:30PM +0200, Reimar D?ffinger wrote:
> On Thu, Jul 02, 2009 at 02:55:56PM +0200, Michael Niedermayer wrote:
> > On Thu, Jul 02, 2009 at 02:35:44PM +0200, Reimar D?ffinger wrote:
> > > Hello,
> > > AFAICT there is no way to demux ASF without knowing the packet size,
> > > thus read_header should already fail instead of crashing at read_packet
> > > when we try to calulate modulus the packet size.
> > 
> > hmm, the packet size should not be essential for demuxing, have you tried
> > to hack the % with something silly?
> 
> Actually demuxing can't work without it, since the ASF file does not have to
> explicitly code that packet_length, it can instead specify that packet_size
> should be used, which then breaks the whole code.

yes but, if a file did not use the default packet size it should work, iam not
at all asking to do anything about files that use the default with it =0
my reasoning was just that the default being 0 cant be worse than there being
an explicit 0, if it causes a crash or such its a bug either way

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090702/572dd72c/attachment.pgp>