[FFmpeg-devel] [PATCH] configure: accept unknown OSes by default

[Diego Biurrun]

On Mon, Jul 06, 2009 at 11:12:19AM +0100, M?ns Rullg?rd wrote:
> Diego Biurrun <diego at biurrun.de> writes:
> 
> > On Mon, Jul 06, 2009 at 10:42:00AM +0100, M?ns Rullg?rd wrote:
> >> Diego Biurrun <diego at biurrun.de> writes:
> >> 
> >> > On Mon, Jul 06, 2009 at 10:26:11AM +0100, M?ns Rullg?rd wrote:
> >> >> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> >> >> 
> >> >> > On Mon, Jul 06, 2009 at 11:03:05AM +0200, Diego Biurrun wrote:
> >> >> >> I'd like to change the default in configure from reject to accept when
> >> >> >> encountering an unknown operating system.  I believe it is the more sane
> >> >> >> default and the last OSes we added just needed empty entries...
> >> >> >
> >> >> > The disadvantage is that if one of the OS that need heavy hacks change
> >> >> > name it will fail in an obscure way instead of during configure, and the
> >> >> > same is true for a typo in --target.
> >> >> 
> >> >> The reason I made it reject unknown OSes was all the people passing
> >> >> crap as --target-os when building for OSX.
> >> >
> >> > Huh?  When was that?
> >> 
> >> Before I made it die instead.
> >> 
> >> >> I'd be OK to have a blank
> >> >> entry with a name like "none" for those willing to try their luck.
> >> >
> >> > What do you mean by a blank entry?
> >> 
> >> One that doesn't do anything.
> >> 
> >> > What about printing a warning instead of dying?
> >> 
> >> We used to do that, and people ignored it.
> >
> > What about dying when we find an invalid entry in target_os then?
> 
> That's exactly what we do now.

I was being imprecise.  Let me try again:

What about dying when we find an unknown entry passed explicitly with
--target-os, but accept unknown values that we autodetected?

Diego