[FFmpeg-devel] Indeo3 maintainer?

[compn]

On Mon, 6 Jul 2009 13:41:57 +0200, Michael Niedermayer wrote:
>On Mon, Jul 06, 2009 at 11:17:06AM +0200, Reimar D?ffinger wrote:
>> On Mon, Jul 06, 2009 at 05:26:05AM +0200, Michael Niedermayer wrote:
>[...]
>> > > The problem seems to me that the code lacks buffer boundary checks all
>> > 
>> > i remembr that .... 
>> > if you think there are missing checks on writng instead of just reading then
>> > iam fine with disabling indeo3 until maxim or someone else can maintain it
>> > properly
>> 
>> Well, reading the code I concluded the issue is mostly (only?) with reference
>> frames, in which case it should only be reads.
>> Unfortunately valgrind says otherwise, which is no surprise with code
>> like that:
>>                 cp2 = s->ModPred + ((lv - 8) << 7);
>>                 cp = ref_frm_pos;
>>                 for(i = 0; i < blks_width << 2; i++) {
>>                     int v = *cp >> 1;
>>                     *(cp++) = cp2[v];
>>                 }
>> 
>> I assumed that ref_frm_pos would be reference frame, but here it is
>> written into.
>> So if nobody can say more about it I think it might be better to disable
>> it by default, 
>
>> I think we've usually done that by commenting out in
>> allcodecs.c, right?
>
>dunno, we didnt disable that much yet but commenting the line there is
>certainly an acceptable choice

would it be better to just make --disable-decoder=indeo3 default?
that way its a simple fix for anyone who still wishes to use indeo3.

one less patch for package maintainers.

-compn