[FFmpeg-devel] [PATCH] add block_align to sox input

[Phil Rutschman]

> > The attached patch uses st->codec->block_align in soxdec.c based on
> the changes in this fix:
> > http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/2009-
> April/022122.html
> >
> 
> Looks ok to me, except Michael will probably say the extra variable is
> not necessary. :)  Plus the formatting is slightly different than the
> rest of the file (no space around * in the size calculation).
> 
> Thanks,
> -- Daniel Verkamp

I chose both of those to match the r18453 checkin to libavformat/raw.c

I'm willing to send an amended patch. Putting an expression directly into the function call yields a line in excess of 80 characters. I looked in doc/developer.texi but didn't find any statement of the preferred treatment of long lines, i.e.:

    ret = av_get_packet(s->pb, pkt, SOX_SAMPLES * s->streams[0]->codec->block_align);

vs

    ret = av_get_packet(s->pb, pkt, SOX_SAMPLES *
                                    s->streams[0]->codec->block_align);

vs
    ret = av_get_packet(s->pb,
                        pkt,
                        SOX_SAMPLES * s->streams[0]->codec->block_align);

What is your preferred convention?