[FFmpeg-devel] [PATCH] Support for UTF8 filenames on Windows

[Ramiro Polla]

On Sun, Jul 12, 2009 at 5:17 PM, Ramiro Polla<ramiro.polla at gmail.com> wrote:
> On Thu, Jul 9, 2009 at 3:32 AM, Ramiro Polla<ramiro.polla at gmail.com> wrote:
>> On Fri, Jun 26, 2009 at 1:10 PM, Karl Blomster<thefluff at uppcon.com> wrote:
>>> Ramiro Polla wrote:
> [...]
>>>> But I'm still not really happy about having to choose at compile-time.
>>>> Is there no way the user could specify it at run-time?
>>>
>>> You could add an enable_win_utf8 parameter to av_open_input_file I guess but
>>> that would be a really ugly thing to have in the API and I doubt it'd be
>>> OK'd. This patch only changes the API, not the commandline interfaces and
>>> whatnot, so the only users of it would be people who use the ffmpeg API, and
>>> those people presumably compile ffmpeg themselves anyway and would know if
>>> they want UTF-8 support or not.
>>
>> I'm thinking of maybe adding a field to URLContext to specify
>> win32_utf8, or adding URL_WIN32_UTF8 to flags. Does anyone have
>> other/better suggestions to let the user choose between the system
>> codepage or utf8 files on Windows at runtime?
>
> I could also use an environment variable. Any comments on any of the
> three approaches?
> 1. add a boolean field to URLContext;
> 2. add a flag to URLContext.flags;
> 3. add an environment variable.

Patch for option 3 attached.

Please comment.

Ramiro Polla
-------------- next part --------------
A non-text attachment was scrubbed...
Name: winutf8.diff
Type: text/x-c
Size: 2628 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090713/c42a7a85/attachment.bin>