[FFmpeg-devel] [PATCH] OpenEXR decoder rev-10

[Jimmy Christensen]

On 2009-07-14 15:32, Diego Biurrun wrote:
> On Wed, Jul 08, 2009 at 08:56:39AM +0200, Jimmy Christensen wrote:
>> --- libavcodec/exr.c	(revision 0)
>> +++ libavcodec/exr.c	(revision 0)
>> @@ -0,0 +1,405 @@
>> +                            // Process other channels
>> +                            if(ptr_tmp<  buf) {
>
> nit: if (
>
>> +                                while(ptr_tmp[0] != 0x0) {
>> +                                    ptr_tmp++;
>> +                                }
>
> pointless {}
>
>> +                    if (*buf) {
>> +                        av_log(avctx, AV_LOG_ERROR, "Doesn't support this line order : %d\n", *buf);
>> +                    }
>
> ditto
>

Missed those two. Fixed now.

> Everything else OK from my side..
>
> Diego

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenEXR-rev10.diff
Type: text/x-patch
Size: 18606 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090714/12a4c910/attachment.bin>