[FFmpeg-devel] [PATCH] atoll() replacement for WinCE

[Måns Rullgård]

Martin Storsj? <martin at martin.st> writes:

> On Wed, 15 Jul 2009, Ramiro Polla wrote:
>
>> 2009/7/15 M?ns Rullg?rd <mans at mansr.com>:
>> >
>> > Oh damn. ?Use (long) then. ?That should be warning-free on most
>> > machines.
>> 
>> I haven't tested, but that should throw a warning in mingw-w64. What's
>> so bad about including stdint.h?
>
> I checked, and yes it does give a warning on mingw-w64. The warning itself 
> is harmless and invisible as long as it's just a warning.
>
> I tried doing it the proper way with stdint.h and intptr_t, and it seems 
> to work fine, too, patch attached.
>
> The reason for avoiding including stdint.h in the test is purity of the 
> tests, I'd say, to be able to check things with as little unnecessary 
> dependencies as possible.
>
> I don't have too much an opinion on this, feel free to choose either this 
> one or the long version that M?ns already approved.

We've had enough problems with stdint.h already.  I prefer the (long)
cast.  The warning is quite harmless.

-- 
M?ns Rullg?rd
mans at mansr.com