[FFmpeg-devel] [PATCH] Support for UTF8 filenames on Windows

[Ramiro Polla]

On Mon, Jul 20, 2009 at 12:12 PM, Michael Niedermayer<michaelni at gmx.at> wrote:
> On Sat, Jul 18, 2009 at 06:52:29PM -0300, Ramiro Polla wrote:
>> On Sat, Jul 18, 2009 at 2:11 PM, Karl Blomster<thefluff at uppcon.com> wrote:
>> > Ramiro Polla wrote:
>> [...]
>> >> 1 - lavf takes in UTF-8. lavf users must convert. No environment
>> >> variables. API breakage.
>> >> 2 - lavf takes in UTF-8 by default, with environment variable to
>> >> select system codepage. ffmpeg always overrides that variable to use
>> >> UTF-8. API breakage. This would be a nuisance to lavf users who want
>> >> to pass filenames from system codepage.
>> >> 3 - lavf takes in system codepage by default, with environment
>> >> variable to select UTF-8. ffmpeg always overrides that variable to use
>> >> UTF-8. No API breakage. This would be a nuisance for lavf users who
>> >> want to pass UTF-8 filenames.
>> >>
>> >> They're all better than the current "0 - no unicode support".
>> >>
>> >> I'm thinking now of aiming towards 3.
>> >
>> > Yeah, 3 would be my preference as well, especially since 1 and 2 would lead
>> > to a rather subtle API breakage: it won't result in something obvious like
>> > your application failing to compile against the new ffmpeg, but rather it'll
>> > just mysteriously fail to open certain files.
>>
>> New patch attached.
>>
>> Taking Michael's comment in consideration:
>> > i do think ffmpeg should be kept be useable om Win9x, because here it
>> > seems you really try to support the more messy/complex MS asshatry while
>> > droping support for the simpler.
>>
>> In this patch, ffmpeg/ffplay test for win9x. If that is the case, the
>> current behavior continues (no unicode). We could support unicode in
>> win9x through MSLU, but that's a whole lot more work and I don't think
>> it's worth it.
>
> i agree
>
> also iam ok with whatever changes are needed to files i maintain as long as
> they are reasonable. That is i think you maintain the win32 code and that
> includes little snippets in "my files", so dont wait for a review from me.
> Of course if you want me to look at some part i can do that ...

Ok, then, I need someone to take a look at the build system part (I
used FF_EXTRA_OBJS but there are some other combinations with less
underscores and I can't tell which one is best). Also another look at
the documentation is always welcome.

Ramiro Polla