[FFmpeg-devel] [PATCH] Bluray Subtitle Support, v4

[Diego Biurrun]

On Tue, Jul 28, 2009 at 07:29:50PM +1000, stev391 at exemail.com.au wrote:
> On Sat, 2009-07-25 at 10:13 +1000, stev391 at exemail.com.au wrote:
> > On Fri, 2009-07-24 at 15:23 +0200, Diego Biurrun wrote:
> > > On Fri, Jul 24, 2009 at 05:57:24PM +1000, stev391 at exemail.com.au wrote:
> > > > 
> > > > Updated patch including Diego's, Aurelien's & Baptiste's comments.
> > > > Thanks for the excellent and quick feedback.
> > > 
> > Thanks again for the comments, I'm glad somebody is interested in my
> > patch.
> > 
> > Updated patch (from v2) to include Diego's & Aurelien's comments.
> 
> Updated patch to version 4.
> 
> Who needs to give the ok for this to be included into FFmpeg?

Michael Niedermayer

> --- libavcodec/pgssubdec.c	(revision 0)
> +++ libavcodec/pgssubdec.c	(revision 0)
> @@ -0,0 +1,452 @@
> +
> +#define cm (ff_cropTbl + MAX_NEG_CROP)
> +#define RGBA(r,g,b,a) (((a) << 24) | ((r) << 16) | ((g) << 8) | (b))

This could be more readable aligned.

> +typedef struct PGSSubPicture {
> +    int w;
> +    int h;
> +    uint8_t *bitmap;
> +} PGSSubPicture;

ditto

> +static av_cold int pgssub_init_decoder(AVCodecContext *avctx)

The pgssub_ prefixes for static functions are pointless, same below.

Diego