[FFmpeg-devel] RTP/SVQ3 payload parser

[Diego Biurrun]

On Wed, Jul 29, 2009 at 12:01:54PM -0400, Ronald S. Bultje wrote:
> 
> On Tue, Jul 28, 2009 at 6:21 PM, Ronald S. Bultje<rsbultje at gmail.com> wrote:
> [..]
> 
> All comments from Diego / Benoit were fixed in this revision.

Hmmm...

> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ ffmpeg-svn/libavformat/rtp_svq3.c	2009-07-29 11:50:53.000000000 -0400
> @@ -0,0 +1,148 @@
> +
> +/**
> + * @file libavformat/rtp-sv3v.c

That ain't right.

> +static int sv3v_parse_sdp_line (AVFormatContext *s, int stream_index,
> +                                PayloadContext *asf, const char *line)
> +
> +static int sv3v_parse_packet (AVFormatContext *s, PayloadContext *sv,
> +                              AVStream *st, AVPacket *pkt,
> +                              uint32_t *timestamp,
> +                              const uint8_t *buf, int len, int flags)
> +
> +static PayloadContext *
> +sv3v_extradata_new(void)
> +
> +static void
> +sv3v_extradata_free(PayloadContext *sv)

K&R please...

And why sv3v instead of svq3?  Prefixes for static functions are
unnecessary in any case.

> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ ffmpeg-svn/libavformat/rtp_svq3.h	2009-07-29 11:54:06.000000000 -0400
> @@ -0,0 +1,33 @@
> +
> +#include "libavcodec/avcodec.h"
> +#include "rtpdec.h"

What are these good for?  You could #include them directly in the C
file.

Diego