[FFmpeg-devel] [PATCH] Pass pointer of correct type for timestamp to ff_rm_parse_packet

[Ronald S. Bultje]

Hi,

On Wed, Jul 29, 2009 at 1:41 PM, Kostya<kostya.shishkov at gmail.com> wrote:
> On Mon, Jul 27, 2009 at 10:43:19AM -0400, Ronald S. Bultje wrote:
>> On Mon, Mar 30, 2009 at 5:07 PM, Eli Friedman<eli.friedman at gmail.com> wrote:
>> > Per subject. ?The actual bug is in the following code in rdt_parse_packet:
>> > ? ? ? ?res = ff_rm_parse_packet (rdt->rmctx, &pb, st,
>> > rdt->rmst[st->index], len, pkt,
>> > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?&seq, &flags, timestamp);
>> >
>> > ff_rm_parse_packet takes a uint64_t* for the timestamp, but it was
>> > getting passed a uint32_t*. ?The fix is spread over a few files
>> > because the pointer in question gets passed through a few different
>> > functions.
>>
>> Attached patch fixes this properly. We changed the code so that
>> ff_rm_parse_packet() no longer returns packet data (it used to), all
>> that is done in separate functions. The result is that this code no
>> longer needs a pointer but just a value (it never updates it). Same
>> for flags. This should fix this issue.
>
> Looks ok

applied.

Ronald