[FFmpeg-devel] rtpdec.c: AXIS 7401 RTCP RR Keep Alive SSRC

[Edward Patton]

>>On Wed, 2009-07-22 at 13:35 -0700, Edward Patton wrote:

>> Hi

>> 

>> I made this change to prevent the AXIS 7401 video server from
timing out when sending H264 RTP streamed video. It appears the AXIS
ignores the clients SSRC when it is the same as the servers SSRC. I
fixed the client SSRC, but its supposed to be a random value (but fixed
for the session). Furthermore, the code should really check to see if
the client/server's SSRC's match and then select a new one. For our
application, it seems to work OK with a fixed SSRC.

>> 

>> This change may be at least better than what is currently in the code base. Should it >>be a patch?



>Can you test the attached patch? I expect it to work, but I prefer to be

>sure (and I have no AXIS servers for testing).





>??????????? Thanks,

>??????????????? Luca


Will do shortly.

Eddie

Author:?Luca Abeni
Date:?2009-07-25?03:372009-07-25 10:37?-700UTC
To:?FFmpeg development discussions and patches
Subject:?Re: [FFmpeg-devel] rtpdec.c: AXIS 7401 RTCP RR Keep Alive SSRC
Hi Edward,



On Wed, 2009-07-22 at 13:35 -0700, Edward Patton wrote:

> Hi

> 

> I made this change to prevent the AXIS 7401 video server from
timing out when sending H264 RTP streamed video. It appears the AXIS
ignores the clients SSRC when it is the same as the servers SSRC. I
fixed the client SSRC, but its supposed to be a random value (but fixed
for the session). Furthermore, the code should really check to see if
the client/server's SSRC's match and then select a new one. For our
application, it seems to work OK with a fixed SSRC.

> 

> This change may be at least better than what is currently in the code base. Should it be a patch?



Can you test the attached patch? I expect it to work, but I prefer to be

sure (and I have no AXIS servers for testing).





????????????Thanks,

????????????????Luca

Index: libavformat/rtpdec.c

===================================================================

--- libavformat/rtpdec.c????(revision 19507)

+++ libavformat/rtpdec.c????(working copy)

@@ -207,7 +207,8 @@

     put_byte(pb, (RTP_VERSION << 6) + 1); /* 1 report block */

     put_byte(pb, 201);

     put_be16(pb, 7); /* length in words - 1 */

-    put_be32(pb, s->ssrc); // our own SSRC

+    // our own SSRC: we use the server's SSRC + 1 to avoid conflicts

+    put_be32(pb, s->ssrc + 1);

     put_be32(pb, s->ssrc); // XXX: should be the server's here!

     // some placeholders we should really fill...

     // RFC 1889/p64

_______________________________________________

ffmpeg-devel mailing list

ffmpeg-devel@???

https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel