[FFmpeg-devel] [PATCH] dump_format after av_write_header

[Michael Niedermayer]

On Sun, Mar 01, 2009 at 03:25:21PM -0800, Baptiste Coudurier wrote:
> Michael Niedermayer wrote:
> > On Fri, Feb 27, 2009 at 10:59:26AM -0800, Baptiste Coudurier wrote:
> >> On 2/27/2009 11:09 AM, Michael Niedermayer wrote:
> >>> On Thu, Feb 26, 2009 at 07:38:38PM -0800, Baptiste Coudurier wrote:
> >>>> Michael Niedermayer wrote:
> >>>>> On Thu, Feb 26, 2009 at 05:17:51PM -0800, Baptiste Coudurier wrote:
> >>>>>> Hi guys,
> >>>>>>
> >>>>>> $subject, this will permit to see how av_write_header sets time_base.
> >>>>> ok
> >>>>>
> >>>> Nice, after checking again, I believe it might be more elegant to print
> >>>> the error at the end, so user can see it easier.
> >>>>
> >>>> How is it ?
> >>>>
> >>>> -- 
> >>>> Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
> >>>> Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
> >>>> checking for life_signs in -lkenny... no
> >>>> FFmpeg maintainer                                  http://www.ffmpeg.org
> >>>> Index: ffmpeg.c
> >>>> ===================================================================
> >>>> --- ffmpeg.c	(revision 17630)
> >>>> +++ ffmpeg.c	(working copy)
> >>>> @@ -1543,6 +1543,8 @@
> >>>>      return -1;
> >>>>  }
> >>>>  
> >>>> +static char error[1024];
> >>>> +
> >>>>  /*
> >>>>   * The following code is the main loop of the file converter
> >>>>   */
> >>> this is ugly, cant a local buffer be used inside a function?
> >> Yes, no problem. Btw what's the advantage ?
> > 
> > purely philosophical :)
> > 
> > (and some people who make ffmpeg.c dlls might be happy about less thread
> >  breakers)
> 
> Ok, update patch attached, I changed break to goto dump_format to keep
> current behavior.

look ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is not what we do, but why we do it that matters.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090302/3581c98d/attachment.pgp>