[FFmpeg-devel] [PATCH] rtpdec.c: don't overwrite pkt->stream_index in finalize_packet()

[Ronald S. Bultje]

Hi Luca,

On Sun, Mar 1, 2009 at 12:11 PM, Luca Abeni <lucabe72 at email.it> wrote:
> No, I was not thinking about this. In my comment about H.264 I was
> referring to the fact that you seem to parse ASF in the codepath used
> for "regular codecs" (s->st != NULL) and to use s->parse_packet to
> distinguish it from other codecs. As H.264 uses s->parse_packet too,
> every time you change something to make ASF over RTP happy you risk to
> change the H.264 payload behaviour too.
[..]
> I was not suggesting to avoid calling rtp_parse_packet()... I was
> suggesting to have s->st = NULL and to behave similarly to TS over RTP
> (which uses rtp_parse_packet() too).

Ok, got it. I'll consider doing this for the future. I think for now,
my (approved :-) ) changes to rtp_parse_packet() have been rather
minimal and just shuffling some code around to match both behaviours
better. My RDT changes were initially in rtp_parse_packet() and that
was indeed way too much. If something like that ever comes up again or
appears necessary for ASF or any of the payloads I try to implement,
I'll separate as you suggested.

Ronald