[FFmpeg-devel] [PATCH] Fix a valgrind error in h264.c

[Ramiro Polla]

Hi,

On Tue, Mar 3, 2009 at 4:57 PM, Vitor Sessak <vitor1001 at gmail.com> wrote:
> Hi,
>
> I was wondering why MinGW fails decoding CVMAPAQP3_Sony_E.jsv in FATE
> (http://fate.multimedia.cx/index.php?build_record=61129), so I tested it
> with valgrind in my box:
>
>> ==10039== Conditional jump or move depends on uninitialised value(s)
>> ==10039== ? ?at 0x8146DD5: ff_print_debug_info (mpegvideo.c:1092)
>> ==10039== ==10039== Conditional jump or move depends on uninitialised
>> value(s)
>> ==10039== ? ?at 0x82A3971: h264_parse (h264_parser.c:55)
>> ==10039== ==10039== Invalid read of size 1
>> ==10039== ? ?at 0x828BFBE: filter_mb (h264.c:6471)
>> ==10039== ?Address 0x49374a3 is not stack'd, malloc'd or (recently) free'd
>
> The attached patch fixes the last one, but I have no familiarity with h264
> code (nor $bignum hours of free time to acquire it) so I don't know if it is
> the right way to fix it...

I spent some time today trying to find out the cause and didn't know
if it was the right way either.

> PS: I don't know either if this actually fixes MinGW or not...

It doesn't fix MinGW, but it does fix the bug in FFmpeg =)

Ramiro Polla