[FFmpeg-devel] [PATCH] libavdevice: JACK demuxer

[Diego Biurrun]

On Wed, Mar 04, 2009 at 02:33:47PM +0100, Olivier Guilyardi wrote:
> Attached: jack demuxer patch 0.8
> 
> --- libavdevice/jack_audio.c	(revision 0)
> +++ libavdevice/jack_audio.c	(revision 0)
> @@ -0,0 +1,330 @@
> +
> +typedef struct {
> +} PrivateData;

I don't understand why people feel the need to typedef their
structs, well, whatever...

> +#if CONFIG_JACK_DEMUXER

The #if is pointless because ..

> --- libavdevice/Makefile	(revision 17804)
> +++ libavdevice/Makefile	(working copy)
> @@ -12,6 +12,7 @@
>  OBJS-$(CONFIG_DV1394_DEMUXER)            += dv1394.o
> +OBJS-$(CONFIG_JACK_DEMUXER)              += jack_audio.o

.. the file is compiled conditional to the very same definition anyway.

Diego