[FFmpeg-devel] [PATCH][8/8] Add VA API deps to configure (take 2)

[Diego Biurrun]

On Fri, Mar 06, 2009 at 11:03:34AM +0100, Gwenole Beauchesne wrote:
> On Tue, 3 Mar 2009, Diego Biurrun wrote:
> 
> > On Tue, Mar 03, 2009 at 01:49:24PM +0100, Gwenole Beauchesne wrote:
> >> On Tue, 3 Mar 2009, Diego Biurrun wrote:
> >>
> >>> On Tue, Mar 03, 2009 at 11:26:07AM +0100, Gwenole Beauchesne wrote:
> >>>>
> >>>> OK, I dropped pkg-config and updated libva. Also sanitized VA API headers
> >>>> so that they build with plain -std=c99. Too bad ISO C does not support
> >>>> anonymous unions yet.
> >>>
> >>> I think you should be able to get rid of the vaapi option altogether,
> >>> like I did for xvmc.  Some suggestions below:
> >>
> >> I think keeping the option is desirable as some people would want to
> >> disable feature X or Y without uninstalling the feature-devel package.
> >
> > --disable-decoder=h264_vaapi
> 
> If you could review my configure part for --*-hwaccel that would be great 
> too. ;-)

Did I miss a patch?  Please ping it, I'm not aware of a patch I
overlooked...

> Does this accept globs?

No.

> Because if you want to disable VA API or VDPAU that's 6 or 5 hwaccels
> to specify. And if there is a new hwaccel, people will generally
> forget about it, unless a glob catches it.

New hwaccels will not appear very often and there is always the output
of configure to check.

Diego