[FFmpeg-devel] [PATCH] VQF demuxer

[Vitor Sessak]

Diego Biurrun wrote:
> On Sat, Mar 07, 2009 at 05:42:59PM +0100, Vitor Sessak wrote:
>> See $subj. This is a pretty simple demuxer, the only non-standard thing  
>> about it is that a frame size in bits is not always a multiple of 8.  
>> I'll post in a separated thread a WIP TwinVQ decoder if anyone wants to  
>> test the demuxer (I've tested it with all the samples in 
>> ftp.mplayerhq.hu).
> 
> Where are the samples?

http://samples.mplayerhq.hu/vqf/

>> --- libavformat/vqf.c	(revision 0)
>> +++ libavformat/vqf.c	(revision 0)
>> @@ -0,0 +1,253 @@
>> +static void add_metadata(AVFormatContext *s, const char *tag, int tag_len,
>> +    int remaining)
> 
> indentation
> 
>> +    if(len != tag_len)
> 
> Space after if, you have it everywhere else.
> 
>> +            st->codec->bit_rate = read_bitrate*1000;
>> +            st->codec->bits_per_coded_sample = 16;
> 
> align
> 
>> +    pkt->pos = url_ftell(s->pb);
>> +    pkt->stream_index = 0;
> 
> align
> 
>> +    c->last_frame_bits = pkt->data[size+1];
>> +    c->remaining_bits = 8*size - c->frame_bit_len + c->remaining_bits;
> 
> align

All fixed locally.

-Vitor