[FFmpeg-devel] [PATCH] MS Video 1 encoder

[Kostya]

On Sat, Mar 07, 2009 at 08:41:04PM +0100, Michael Niedermayer wrote:
> On Sat, Mar 07, 2009 at 09:32:49AM +0200, Kostya wrote:
[...]
> 
> > +#include "libavutil/random.h"
> 
> Do you really need the MT? isnt a LFG good enough?
 
Of course not.
Will change the code to use LFG.
Also this rises he question why it is still the default one.
Release is over, we(you) can change it to LFG.

[...]
> > +
> > +    p->quality = avctx->global_quality;
> > +    qshift = avctx->global_quality / FF_QUALITY_SCALE;
> > +    qshift >>= 1; //range 0-16 should be enough here
> 
> its
> SSE + bits*quality^2*SomeConstant IIRC
> 
> the log and shift stuff is because of the way H264 defines their QP
> you are not writing a h264 codec

I feared to read "yet" here :S

> and even if you did, you could freely
> choose how to define your internal scales.
> log/exp is mildly annoying ...
> 
> besides global_quality is not defined over H264 QP 

Actually it's set from -qscale commandline parameter which is the
reason I've used it.
 
[...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB