[FFmpeg-devel] [PATCH] MS Video 1 encoder

[Michael Niedermayer]

On Sun, Mar 08, 2009 at 05:01:40PM +0100, Vitor Sessak wrote:
> Kostya wrote:
>> On Sun, Mar 08, 2009 at 03:59:18PM +0100, Michael Niedermayer wrote:
>>> On Sun, Mar 08, 2009 at 12:21:32PM +0200, Kostya wrote:
>>>> On Sat, Mar 07, 2009 at 08:41:04PM +0100, Michael Niedermayer wrote:
>>>>> On Sat, Mar 07, 2009 at 09:32:49AM +0200, Kostya wrote:
>>>>>> On Sat, Mar 07, 2009 at 01:40:49AM +0100, Michael Niedermayer wrote:
>>>>>>> On Fri, Mar 06, 2009 at 08:57:22PM +0200, Kostya wrote:
>>>>>>>> $subj
>>>>>>>>
>>>>>>>> It works more or less fine to me (except the codec itself being 
>>>>>>>> utter crap).
>>>>>>>> You can even set quality with -qscale flag to get different grades 
>>>>>>>> of bad
>>>>>>>> quality.
>>>>>>>>
>>>>>>>> This codec may serve two goals: having video codec supported on 
>>>>>>>> Windows by
>>>>>>>> default and (in the future) making regtests run even slower causing 
>>>>>>>> timeouts
>>>>>>>> on FATE.
>>>> [...]
>>>>>> Index: libavcodec/msvideo1enc.c
>>>>>> ===================================================================
>>>>>> --- libavcodec/msvideo1enc.c	(revision 0)
>>>>>> +++ libavcodec/msvideo1enc.c	(revision 0)
>>>>> [...]
>>>>>> +#include "avcodec.h"
>>>>>> +#include "bytestream.h"
>>>>>> +#include "libavutil/random.h"
>>>>> Do you really need the MT? isnt a LFG good enough?
>>>>  It turned out that I don't need it but ELBG does.
>>> as random.* is no longer part of the public API/ABI you cant use it from
>>> outside libavutil no matter what excuse.
>>  I'll switch codecs I maintain to LFG but somebody has to do something 
>> with
>> ELBG and RoQ encoder that uses it.
>
> Patch attached.

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct awnser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090308/3f5475cc/attachment.pgp>