[FFmpeg-devel] [PATCH] mov.c: factorize ff_mov_read_stsd_entries()

[Baptiste Coudurier]

Hi Michael,

On 3/9/2009 4:33 PM, Michael Niedermayer wrote:
> On Mon, Mar 09, 2009 at 07:17:53PM -0400, Ronald S. Bultje wrote:
>> Hi Baptiste,
>>
>> On Mon, Mar 9, 2009 at 6:57 PM, Baptiste Coudurier
>> <baptiste.coudurier at gmail.com> wrote:
>>> I think Palette must be in MOVStsd anyway, and palette stuff is
>>> deprecated ...
>>> Demuxer will gather palette from MOVStsd if it needs too, and update
>>> MOVContext if needed.
> 
>> I like this. Ideally, whatever we choose, it'd automatically update
>> that structure (AVCodecContext?) that needs the palette for ffplay to
> 
> as a saftey reminder to everyone:
> The decoder and demuxer can (and do for ffplay) run in seperate threads
> updating fields in AVCodecContext (like the palette) during playback is
> NOT possible the threads with a AVPacket que between them will entangle
> 
> all changes during playback must go through AVPackets, this is why all
> the palette stuff has been deprecated.
> palettes can either be passed through
> * extradata (this implicates they never change during the file)
> OR
> * AVPackets

For mov then I guess it should be in extradata, since palette is in stsd.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org