[FFmpeg-devel] [PATCH][VAAPI][2/6] Add common data structures and helpers (take 6)

[Gwenole Beauchesne]

Le 11 mars 09 ? 21:29, Michael Niedermayer a ?crit :

> On Wed, Mar 11, 2009 at 06:45:28AM +0100, Gwenole Beauchesne wrote:
>> Le 11 mars 09 ? 02:10, Michael Niedermayer a ?crit :
>>
>>>> +/** Destroy VA API render state buffers */
>>>> +static void vaapi_render_state_fini(struct
>>>> vaapi_render_state_private *rds)
>>>
>>> the vaapi_ prefixes are still useless
>>
>> vaapi_render_state is the name of the struct...
>
> yes but why?
> also the function name is simply too long

The function vanished (see take 7 or 8).

>>>> + */
>>>> +struct vaapi_render_state {
>>>
>>>> +    struct vaapi_context *va_context;   ///< Pointer to display-
>>>> dependent data
>>>
>>> why this pointer? why are the fields not added to this struct?
>>
>> Simplification for the user to avoid copies since those don't change
>> for a specific surface.
>
> if its "global" and not surface specific then it also doesnt belong
> in AVFrame
> a field in AVCodecContext would make more sense

The problem is we start to get too many HW accel data pieces among  
various places: data[3] (surface id), hwaccel_data_private, and now  
possibly an AVCodecContext.hwaccel_context?

A user will likely forget about one... though the latter is optional.