[FFmpeg-devel] [PATCH][VAAPI][2/6] Add common data structures and helpers (take 9)

[Michael Niedermayer]

On Thu, Mar 12, 2009 at 06:09:08AM +0100, Gwenole Beauchesne wrote:
> Le 12 mars 09 ? 01:27, Michael Niedermayer a ?crit :
> 
> >> +{
> >> +    const struct vaapi_context *va_context = avctx->hwaccel_context;
> >> +    struct vaapi_hwaccel_data_private * const p = pic- 
> >> >hwaccel_data_private;
> >
> > the structs should be named in a way that makes it obvious which is
> > "global" and which is per frame like
> > hwaccel_frame/surface/..._private or so
> 
> The current names are obvious.
> - vaapi_context derived from and accessed from  
> AVCodecContext.hwaccel_context

> - vaapi_hwaccel_data_private derived from and accessed from  
> Picture.hwaccel_data_private

both are bad, both should be changed


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090312/976130b2/attachment.pgp>