[FFmpeg-devel] [PATCH] libavdevice: JACK demuxer
Diego Biurrun
diego
Sat Mar 14 10:52:36 CET 2009
On Fri, Mar 13, 2009 at 09:05:38PM +0100, Olivier Guilyardi wrote:
> Attached: jack demuxer 0.10
>
> --- configure (revision 17951)
> +++ configure (working copy)
OK
> --- libavformat/Makefile (revision 17951)
> +++ libavformat/Makefile (working copy)
> @@ -80,6 +80,7 @@
> OBJS-$(CONFIG_IPMOVIE_DEMUXER) += ipmovie.o
> OBJS-$(CONFIG_IPOD_MUXER) += movenc.o riff.o isom.o avc.o
> OBJS-$(CONFIG_ISS_DEMUXER) += iss.o
> +OBJS-$(CONFIG_JACK_DEMUXER) += timefilter.o
> OBJS-$(CONFIG_LMLM4_DEMUXER) += lmlm4.o
> OBJS-$(CONFIG_M4V_DEMUXER) += raw.o
> OBJS-$(CONFIG_M4V_MUXER) += raw.o
You should create a separate section for external dependencies, compare
libavcodec/Makefile.
Also, I wonder why timefilter.c is not in the libavdevice subdirectory.
Michael?
> --- libavdevice/jack_audio.c (revision 0)
> +++ libavdevice/jack_audio.c (revision 0)
> @@ -0,0 +1,349 @@
> +
> +/**
> + * Size of the internal fifo buffers as a number of audio packets
FIFO
> +static void free_pkt_fifo(AVFifoBuffer *fifo) {
Please consistently use K&R function declarations, i.e. place the { on
the next line.
A changelog and docs update is missing.
Diego
More information about the ffmpeg-devel
mailing list