[FFmpeg-devel] [PATCH] libavdevice: JACK demuxer

[Olivier Guilyardi]

Hi,

Attached: jack demuxer patch 0.11

Diego Biurrun wrote:
> On Fri, Mar 13, 2009 at 09:05:38PM +0100, Olivier Guilyardi wrote:
>> Attached: jack demuxer 0.10
>>
>> --- configure	(revision 17951)
>> +++ configure	(working copy)
> 
> OK
> 
>> --- libavformat/Makefile	(revision 17951)
>> +++ libavformat/Makefile	(working copy)
>> @@ -80,6 +80,7 @@
>>  OBJS-$(CONFIG_IPMOVIE_DEMUXER)           += ipmovie.o
>>  OBJS-$(CONFIG_IPOD_MUXER)                += movenc.o riff.o isom.o avc.o
>>  OBJS-$(CONFIG_ISS_DEMUXER)               += iss.o
>> +OBJS-$(CONFIG_JACK_DEMUXER)              += timefilter.o
>>  OBJS-$(CONFIG_LMLM4_DEMUXER)             += lmlm4.o
>>  OBJS-$(CONFIG_M4V_DEMUXER)               += raw.o
>>  OBJS-$(CONFIG_M4V_MUXER)                 += raw.o
> 
> You should create a separate section for external dependencies, compare
> libavcodec/Makefile.

Done. I created a "libavdevice dependencies" section.

 >> --- libavdevice/jack_audio.c	(revision 0)
>> +++ libavdevice/jack_audio.c	(revision 0)
>> @@ -0,0 +1,349 @@
>> +
>> +/**
>> + * Size of the internal fifo buffers as a number of audio packets
> 
> FIFO

Ok

> 
>> +static void free_pkt_fifo(AVFifoBuffer *fifo) {
> 
> Please consistently use K&R function declarations, i.e. place the { on
> the next line.

Ok

> 
> A changelog and docs update is missing.

Done for the changelog, but which docs are you talking about?

--
  Olivier
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg-r18021-jack-0.11.patch
Type: text/x-patch
Size: 14341 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090317/a62eac7e/attachment.bin>