[FFmpeg-devel] [PATCH] Do not assume long is same width as x86 register in swscale.

[Diego Biurrun]

On Tue, Mar 17, 2009 at 11:57:19AM +0000, M?ns Rullg?rd wrote:
> Diego Biurrun <diego at biurrun.de> writes:
> 
> > On Mon, Mar 16, 2009 at 08:51:49PM -0300, Ramiro Polla wrote:
> >> 
> >> On Mon, Mar 16, 2009 at 5:37 PM, Reimar D?ffinger
> >> <Reimar.Doeffinger at gmx.de> wrote:
> >> > On Mon, Mar 16, 2009 at 05:18:45PM -0300, Ramiro Polla wrote:
> >> >> swscale-example crashes on funnyYCode (couldn't there be a better name
> >> >> for this?). I'll look further later but I'm guessing it has something
> >> >> to do with the OS not allowing malloc'd code to run.
> >> >
> >> > http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2005-February/033374.html
> >> 
> >> Thanks, that worked (_WIN32 instead of WIN32 though, and adding an
> >> #include <windows.h>).
> >> 
> >> Now I have a question (Mans, Diego):
> >> Since the code is in an external repo (swscale), should FFmpeg's
> >> configure check for Virtual{Alloc,Free} and use it under that ifdef?
> >> Or is ifdefing _WIN32 ok?
> >
> > I have no idea what you are referring to.  Maybe I will understand if you
> > send a patch..
> 
> Follow the link above.  A patch awaits at the other end.

I don't like it, there should be a feature check in configure.

Diego