[FFmpeg-devel] [PATCH] libavdevice: JACK demuxer

[Olivier Guilyardi]

Diego Biurrun wrote:
> On Tue, Mar 17, 2009 at 12:40:13PM +0100, Olivier Guilyardi wrote:
>> Diego Biurrun wrote:
>>> A changelog and docs update is missing.
>> Done for the changelog, but which docs are you talking about?
> 
> doc/general.texi

There's nothing about devices in there. Neither about oss, alsa, v4l, etc...

Plus if this is really about documenting, the presentation/structure of
general.texi doesn't fit the job IMO. The one thing that is important to
document is that the input "filename" must be the jack client name. I don't see
where to put that in the layout of general.texi.

>> --- Changelog	(revision 18021)
>> +++ Changelog	(working copy)
>> @@ -4,6 +4,7 @@
>>  - deprecated vhook subsystem removed
>>  - deprecated old scaler removed
>>  - VQF demuxer
>> +- JACK demuxer
> 
> Maybe you could write "JACK device demuxer" or similar to differentiate
> this from file demuxers?  The entry for ALSA reads
> 
>   - ALSA support for playback and record

"Record" isn't the right word here IMO. You might be reading audio data from
alsa and streaming it live, thus not recording anything.

What about "JACK Audio Connection Kit input device"?
Or the simpler (a bit obscure though) "JACK input device"?

>> --- libavformat/Makefile	(revision 18021)
>> +++ libavformat/Makefile	(working copy)
>> @@ -240,4 +240,7 @@
>>  
>> +# libavdevice dependencies
>> +OBJS-$(CONFIG_JACK_DEMUXER)              += timefilter.o
> 
> I still wonder if we cannot move this to libavdevice.  Michael?

--
  Olivier